Notification Policy - Pull Request comment not auto-resolved

By default, Pull Request comments (as outlined in the docs:

https://docs.spacelift.io/concepts/policy/notification-policy#creating-a-pr-comment) are auto-resolved/closed - at least on Azure DevOps. This default behaviour is fine for the built-in PR integration which simply reports proposed changes on a PR run back to the Azure DevOps UI itself.

However, if the Notification policy is being used to flag something which requires user input, it would be useful to be able to turn off this auto-resolution behaviour. That way the comment would act like a normal user comment which needs some action (or discussion) to resolve. Without this, comments can be ignored and changes can be merged without any action being taken.

On Azure DevOps this is enforced under Repos > Policy > Check for comment resolution.

On Github is looks like there is a “Require conversation resolution before merging” setting.

Something like this could be implemented:

package spacelift

pull_request contains {
  "commit": run.commit.hash,
  "body": "",
  "auto-resolve": false,
} if {
  ...
}

Where the auto-resolve input defaults to true, so as not to break existing behaviour.

Workaround
No, the Pull Request author just has to be reminded to read all comments. There is no mechanism to force them to close all comments before merging.
Problem
Pull Request comments can be ignored as they auto-resolve

Please authenticate to join the conversation.

Upvoters
Status

👀 In Review

Board

💡 Feature Requests

Date

About 11 hours ago

Subscribe to post

Get notified by email when there are changes.